Skip to content

Wipe space for crypt header on unencrypted pool creation #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

jbaublitz
Copy link
Member

No description provided.

@jbaublitz jbaublitz requested a review from mulkieran February 6, 2025 19:45
@jbaublitz jbaublitz self-assigned this Feb 6, 2025
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3756
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

2 similar comments
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3756
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3756
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@drckeefe drckeefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested stratisd build by trying to create a pool with an old encrypted header and the pool create worked.

@mulkieran
Copy link
Member

rebased

@mulkieran
Copy link
Member

current pool level metadata features contains error_if_no_space, already written metadata doesn't. Since we've never seen this before, I'm just gonna view this as a lag in writing the metadata, not a bug. Re-running test.

@mulkieran mulkieran merged commit 32e98ce into stratis-storage:master Feb 8, 2025
47 checks passed
@jbaublitz jbaublitz deleted the wipe-crypt branch February 13, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done (1)
Development

Successfully merging this pull request may close these issues.

3 participants