Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setter on StrawberryAnnotation.annotation #2932

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Conversation

patrick91
Copy link
Member

Fixes this issue on Strawberry Django:

AttributeError: property 'annotation' of 'StrawberryAnnotation' object has no setter

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #2932 (d0d211c) into main (d96c665) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2932   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files         211      211           
  Lines        9228     9231    +3     
  Branches     1706     1707    +1     
=======================================
+ Hits         8875     8878    +3     
  Misses        227      227           
  Partials      126      126           

@botberry
Copy link
Member

botberry commented Jul 8, 2023

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release adds a setter on StrawberryAnnotation.annotation, this fixes
an issue on Strawberry Django.


Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@patrick91 patrick91 merged commit 8c2ac12 into main Jul 8, 2023
39 checks passed
@patrick91 patrick91 deleted the missing-setter branch July 8, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants