Skip to content

Commit

Permalink
fix: bring package version back in sync
Browse files Browse the repository at this point in the history
This commit brings the library version back in sync with the
package.json. It also fixes a smenatic release issue where it was not
detecting the verison number changes.
  • Loading branch information
luqven committed Jul 31, 2021
1 parent 7cb8388 commit a285f36
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,13 @@
"replacements": [
{
"files": [
"src/Luminous.js"
"src/js/Luminous.js"
],
"from": "this.VERSION = '.*'",
"to": "this.VERSION = '${nextRelease.version}'",
"from": "this.VERSION = \".*\"",
"to": "this.VERSION = \"${nextRelease.version}\"",
"results": [
{
"file": "src/Luminous.js",
"file": "src/js/Luminous.js",
"hasChanged": true,
"numMatches": 1,
"numReplacements": 1
Expand Down
12 changes: 7 additions & 5 deletions src/js/Luminous.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default class Luminous {
* @param {Object=} options Luminous options
*/
constructor(trigger, options = {}) {
this.VERSION = "2.3.3";
this.VERSION = "2.3.4";
this.destroy = this.destroy.bind(this);
this.open = this.open.bind(this);
this.close = this.close.bind(this);
Expand Down Expand Up @@ -45,7 +45,8 @@ export default class Luminous {
// The event to listen to on the _lightbox_ element: triggers closing.
const closeTrigger = options["closeTrigger"] || "click";
// Allow closing by pressing escape.
const closeWithEscape = "closeWithEscape" in options ? !!options["closeWithEscape"] : true;
const closeWithEscape =
"closeWithEscape" in options ? !!options["closeWithEscape"] : true;
// Automatically close when the page is scrolled.
const closeOnScroll = options["closeOnScroll"] || false;
const closeButtonEnabled =
Expand All @@ -67,7 +68,8 @@ export default class Luminous {
const includeImgixJSClass = options["includeImgixJSClass"] || false;
// Add base styles to the page. See the "Theming"
// section of README.md for more information.
const injectBaseStyles = "injectBaseStyles" in options ? !!options["injectBaseStyles"] : true;
const injectBaseStyles =
"injectBaseStyles" in options ? !!options["injectBaseStyles"] : true;
// Internal use only!
const _gallery = options["_gallery"] || null;
const _arrowNavigation = options["_arrowNavigation"] || null;
Expand All @@ -88,7 +90,7 @@ export default class Luminous {
includeImgixJSClass,
injectBaseStyles,
_gallery,
_arrowNavigation
_arrowNavigation,
};

let injectionRoot = document.body;
Expand Down Expand Up @@ -171,7 +173,7 @@ export default class Luminous {
_gallery: this.settings._gallery,
_arrowNavigation: this.settings._arrowNavigation,
closeTrigger: this.settings.closeTrigger,
onClose: this.close
onClose: this.close,
});
}

Expand Down

0 comments on commit a285f36

Please sign in to comment.