Merge pull request #27 from imgix/26-null-firefox-caption

Only show caption if the attribute is present
strawdynamics · Aug 4, 2016 · edc1316 · edc1316
2 parents 9bc9fa6 + ee94ed2
commit edc1316
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/dist/Luminous.js b/dist/Luminous.js
@@ -200,8 +200,9 @@ var Lightbox = function () {
     key: '_updateCaption',
     value: function _updateCaption() {
       var captionAttr = this.settings.captionAttribute;
-      if (captionAttr) {
-        this.captionEl.innerText = this.currentTrigger.getAttribute(captionAttr);
+      var caption = this.currentTrigger.getAttribute(captionAttr);
+      if (captionAttr && caption) {
+        this.captionEl.innerText = caption;
       }
     }
   }, {