🐛 Improve thumbnail upload; force 16:9 aspect ratio and fix overflow issues #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Just noticing that uploading a thumbnail does not actually work before uploading a video |
xannyxs
changed the title
This reverts commit 998f9aa.
|
Found an new error in the tests. Will create an issue of it for another PR |
This was referenced Aug 26, 2024
xannyxs
added a commit
that referenced
this pull request
Aug 28, 2024
# Pull Request Info ## Description My last PR (#865) improved the image uploading UX. Those fixes were apparently breaking the forms. I reread the documentation of `react-dropzone` and hopefully found a solution. The automatic and manual tests work as they normally do. Fixes #902 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent overflow and future complications, this PR implements a forced resize of images to 1280x720 pixels (16:9 ratio). If the original image is smaller than this size, black bars are added to maintain the aspect ratio. This approach aligns with YouTube's thumbnail guidelines.
Type of change
Implementation Details
ImageUploadcomponent aDropzoneFuture Work
Further in-depth work on this feature will be addressed in issue #868
Reference
The approach taken is based on YouTube's guidelines: