Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement lutimes #1065

Closed
wants to merge 22 commits into from

Conversation

BadIdeaException
Copy link
Contributor

Added implementation of lutimes including tests. Permissions are respected.

@BadIdeaException
Copy link
Contributor Author

I don't know why Github insists on putting all the old (already merged) commits about permissions into this. I synced my fork thinking this should establish a new baseline, but apparently not.

@G-Rath
Copy link
Collaborator

G-Rath commented Oct 1, 2024

@BadIdeaException probably because you previously pushed your commits directly to your forks default branch rather than a dedicated branch, and I squashed when merging - so technically while all the changes are in this repo, the commits that you've got are not.

You should be able to resolve that by

  1. recreate the default branch in your fork
  2. manually squash all the commits into one on your feature branch
  3. rebase your feature branch onto your default branch

(2. is required to ensure conflicts as git will only consider each commit in isolation and our squashed commit represents the final product which might not be compatible with each individual commit - alternatively, you could do something like create a new branch from the updated default branch, cherry-pick your new commits, then force push to your existing branch)

joscha and others added 6 commits October 2, 2024 16:08
* streamich#735 - add parentPath property to Dirent

* streamich#735 - fix tests for parentPath property

* streamich#735 - use Dirent parentPath instead of path in Volume
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# [4.12.0](streamich/memfs@v4.11.2...v4.12.0) (2024-09-19)

### Features

* improve permissions support ([streamich#1059](streamich#1059)) ([575a76b](streamich@575a76b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants