-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement lutimes #1065
feat: implement lutimes #1065
Conversation
While files are not a permitted place to create subdirectories in, the proper error should be ENOTDIR, not EACCES
I don't know why Github insists on putting all the old (already merged) commits about permissions into this. I synced my fork thinking this should establish a new baseline, but apparently not. |
@BadIdeaException probably because you previously pushed your commits directly to your forks default branch rather than a dedicated branch, and I squashed when merging - so technically while all the changes are in this repo, the commits that you've got are not. You should be able to resolve that by
(2. is required to ensure conflicts as git will only consider each commit in isolation and our squashed commit represents the final product which might not be compatible with each individual commit - alternatively, you could do something like create a new branch from the updated default branch, cherry-pick your new commits, then force push to your existing branch) |
* streamich#735 - add parentPath property to Dirent * streamich#735 - fix tests for parentPath property * streamich#735 - use Dirent parentPath instead of path in Volume
## [4.11.2](streamich/memfs@v4.11.1...v4.11.2) (2024-09-17) ### Bug Fixes * add `parentPath` to `Dirent` ([streamich#1058](streamich#1058)) ([9156c84](streamich@9156c84)), closes [streamich#735](streamich#735) [streamich#735](streamich#735)
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.19.2...4.21.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# [4.12.0](streamich/memfs@v4.11.2...v4.12.0) (2024-09-19) ### Features * improve permissions support ([streamich#1059](streamich#1059)) ([575a76b](streamich@575a76b))
be58783
to
dd3f74d
Compare
Added implementation of
lutimes
including tests. Permissions are respected.