-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch from process.nextTick()
to queueMicrotask()
#941
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
process.nextTick()
to queueMicrotask()
process.nextTick()
to queueMicrotask()
…thout considering existing PRs
59396fa
to
c195361
Compare
@streamich @G-Rath Kindly request your attention with a friendly ping. It has been more than a month since I opened this PR. During this time, I've rebased my PR on top of your pushes many times. I would greatly appreciate it if you could spare some time to review it, at your convenience, and provide your valuable feedback. I know it would be annoying for you to receive a "ping" like this. However, considering that almost every |
@SukkaW you've rebased this 2-3 times at most - I do my best to keep on top of the open source repositories I help maintain but my time is finite. This pull request is not one I'd consider critical which is why I have not jumped on it (as it will probably be landed as a refactor it's not even going to be released by itself); your weekly spamming of me as well as sass in your latest commit did not help make me enthusiastic about your work here. As it happens I will have time tomorrow I can spend landing this but do not take that as a promise since my personal life takes priority. Also please don't take this as a request not to continue contributing - I appreciate the support, so long as you understand the priorities; likewise feel free to mention if a particular PR would resolve a particular issue you're having, to get that prioritized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
🎉 This PR is included in version 4.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The PR closes #934.
The PR does the following things:
queueMicrotask
ponyfillqueueMicrotask
when available, and will fallback toPromise.resolve().then
otherwise.process.nextTick
withqueueMicrotask
process.nextTick
has a function signature ofprocess.nextTick(fn, ...fnArgs)
(passing arguments as rest parameters), whilequeueMicrotask
does not have...fnArgs
.nextTick
implementation and test casesnextTick
from theprocess
ponyfill and its type definitionAlso a question: should we also replace
setImmediate
withqueueMicrotask
? Both of them will flush the callback after microtask queue has emptied.