Skip to content

Electron 25 deprecations #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Electron 25 deprecations #4779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/services/platform-apps/api/modules/authorization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,10 @@ export class AuthorizationModule extends Module {
win.webContents.openDevTools({ mode: 'detach' });
}

win.webContents.session.protocol.registerFileProtocol('slobs-oauth', req => {
win.webContents.session.protocol.handle('slobs-oauth', req => {
eventHandler({ type: EAuthWindowEventType.AuthRedirect, url: req.url });
win.close();
return new Response();
});

win.on('closed', () => {
Expand Down
7 changes: 3 additions & 4 deletions updater/bundle-updater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,17 +405,16 @@ module.exports = async (basePath: string) => {
e.returnValue = bundleNames;
});

electron.session.defaultSession?.protocol.registerFileProtocol('slbundle', (request, cb) => {
electron.session.defaultSession?.protocol.handle('slbundle', request => {
const url = new URL(request.url);
const bundleName = url.pathname.replace('/', '') as TBundleName;

if (!useLocalBundles && bundlePathsMap[bundleName]) {
cb({ path: bundlePathsMap[bundleName] });
return;
return electron.net.fetch(bundlePathsMap[bundleName]);
}

console.log(`Using local bundle for ${bundleName}`);
cb({ path: path.join(localBase, localManifest[bundleName]) });
return electron.net.fetch(path.join(localBase, localManifest[bundleName]));
});

// Use a local web server to serve source maps in development.
Expand Down