Skip to content

add comment that explains literal value + rename ms -> interval #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandboxcoder merged 1 commit into from
Oct 8, 2025
Merged

add comment that explains literal value + rename ms -> interval #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions browser-mac.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ void DoCefMessageLoop(int)
});
}

void DoCefMessageLoopTimer(float ms)
void DoCefMessageLoopTimer(float interval)
{
cefTimer = [NSTimer
scheduledTimerWithTimeInterval:ms
scheduledTimerWithTimeInterval:interval
repeats:YES
block:^(NSTimer *) {
CefDoMessageLoopWork();
Expand Down
3 changes: 2 additions & 1 deletion obs-browser-plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,8 @@ extern "C" EXPORT void obs_browser_initialize(obs_data_t *settings)

ExecuteTask([&settings]() {
BrowserInit(settings);
DoCefMessageLoopTimer(0.01f); // Do not block the main queue so we avoid calling CefRunMessageLoop()
const float interval = 0.01f; // 10ms, for ex. 16.6ms = 60fps. We want a bit more than 60fps to keep CEF happy?
DoCefMessageLoopTimer(interval); // Do not block the main queue so we avoid calling CefRunMessageLoop()
});
#else
auto binded_fn = bind(BrowserManagerThread, settings);
Expand Down
Loading