-
Notifications
You must be signed in to change notification settings - Fork 71
Support authorization policy config #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds configurable Istio AuthorizationPolicy support for ZooKeeper, BookKeeper, AutoRecovery, and Broker via Helm values, enabling teams to restrict traffic by source and HTTP operation fields when istio.enabled is true.
- Introduces authorizationPolicy.from and authorizationPolicy.operation (methods/paths/hosts) values for each component
- Updates the corresponding AuthorizationPolicy templates to render optional from/methods/paths/hosts blocks
- Minor YAML/quoting cleanups
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
charts/sn-platform/values.yaml | Adds authorizationPolicy configuration blocks for components; minor quoting changes; introduces a YAML issue in pulsar_coordinator.component. |
charts/sn-platform/templates/zookeeper/zookeeper-authorizationpolicy.yaml | Renders optional from and operation (methods/paths/hosts) under the ZK AuthorizationPolicy. |
charts/sn-platform/templates/broker/broker-authorizationpolicy.yaml | Renders optional from and operation (methods/paths/hosts) under the Broker AuthorizationPolicy. |
charts/sn-platform/templates/bookkeeper/bookkeeper-authorizationpolicy.yaml | Renders optional from and operation for BookKeeper and AutoRecovery AuthorizationPolicies. |
charts/sn-platform-slim/values.yaml | Mirrors authorizationPolicy configuration blocks and introduces the same pulsar_coordinator.component YAML issue. |
charts/sn-platform-slim/templates/zookeeper/zookeeper-authorizationpolicy.yaml | Same optional from and operation rendering for ZK in slim chart. |
charts/sn-platform-slim/templates/broker/broker-authorizationpolicy.yaml | Same optional from and operation rendering for Broker in slim chart. |
charts/sn-platform-slim/templates/bookkeeper/bookkeeper-authorizationpolicy.yaml | Same optional from and operation rendering for BookKeeper and AutoRecovery in slim chart. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3b2119a
to
8428a75
Compare
8428a75
to
eb8e27a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (4)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Master https://github.com/streamnative/eng-support-tickets/issues/3263
Example