Implement AuthenticationProviderMTls #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coderzc:Thanks for your contribution. For this PR, do we need to update docs? |
coderzc
force-pushed
the
implement_auth_mtls_provider
branch
2 times, most recently
from
de6da6c
to
c112cb2
Compare
coderzc
force-pushed
the
implement_auth_mtls_provider
branch
from
669f19f
to
5219890
Compare
coderzc
commented
Sep 6, 2024
| * limitations under the License. | ||
| */ | ||
| // Copy from sn-pulsar-plugins, only used to compile stage | ||
| package io.streamnative.oidc.broker.common; |
There was a problem hiding this comment.
To successfully deserialize the Pool object, I copied it from sn-pulsar-plugins
Not sure if it conflicts with the package on sn-pulsar-plugins, if conflicts we may
need to exclude this package when building nar.
coderzc
force-pushed
the
implement_auth_mtls_provider
branch
from
86a43e9
to
304ca1d
Compare
coderzc
force-pushed
the
implement_auth_mtls_provider
branch
from
304ca1d
to
e54fdaa
Compare
Technoboy-
approved these changes
Sep 9, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit a7f2688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: https://github.com/streamnative/snip/pull/79
Motivation
Implement AuthenticationProviderMTls for Support mTLS Authentication (Identity pool) on MoP
Modifications
Implement AuthenticationProviderMTls
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)