Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: range scan more than one onError callback #205

Merged
merged 5 commits into from
Jan 26, 2025
Merged

fix: range scan more than one onError callback #205

merged 5 commits into from
Jan 26, 2025

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Jan 26, 2025 •
edited
Loading

Motivation

Fix more than one onError callback from rangeScan interface. You can check example.ranscan.callback for reproduce.

Modification

  • Be sure to call only once between onCompleted and onError.
  • Reduce the code complexity.

@mattisonchao mattisonchao self-assigned this Jan 26, 2025
@mattisonchao mattisonchao merged commit 6e5b0fa into main Jan 26, 2025
1 check passed
@mattisonchao mattisonchao deleted the rangescan.callback branch January 26, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

@merlimat merlimat Awaiting requested review from merlimat merlimat is a code owner

@coderzc coderzc Awaiting requested review from coderzc coderzc is a code owner

Assignees

@mattisonchao mattisonchao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattisonchao @RobertIndie