Remove cluster name from recently viewed topic card #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hemahg <hhg@redhat.com>
MikeEdgar
reviewed
Feb 25, 2025
| @@ -177,6 +186,7 @@ export async function setTopicAsViewed(kafkaId: string, topicId: string) { | |||
| topicId, | |||
| // name is included in the `fields[topics]` param list so we are sure it is present | |||
| topicName: topic.attributes.name!, | |||
| topicStatus: topic.attributes.status!, | |||
There was a problem hiding this comment.
Just something to be aware of is that the topic status in the overview card will always have the status that it had at the point it was last viewed. Are we OK with that? Having the status be up-to-date would require getViewedTopics to be more complex to actually load the topics fresh.
There was a problem hiding this comment.
Thinking about this again, maybe it would be better to just list the topic name and not the status to avoid it being stale? What do you think @hemahg @shirimordechay ?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove cluster name from recently viewed topic card
Add topic status to the recently viewed topic card