Add proposal for integrating Bridge with Metrics Reporter #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
ppatierno
reviewed
Dec 20, 2024
ppatierno
reviewed
Dec 20, 2024
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
force-pushed
the
bridge-metrics
branch
from
bc91100 to
5ffcbc9
Compare
|
@ppatierno thanks for the review. I reworked the proposal to always present the Bridge changes first, and addressed the other comments. |
fvaleri
force-pushed
the
bridge-metrics
branch
5 times, most recently
from
7507129 to
e9bb397
Compare
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
force-pushed
the
bridge-metrics
branch
from
e9bb397 to
328e9cc
Compare
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
force-pushed
the
bridge-metrics
branch
from
54e32b3 to
29076de
Compare
ppatierno
reviewed
Jan 7, 2025
ppatierno
requested review from
tombentley,
scholzj,
Frawless,
katheris,
sknot-rh,
see-quick,
samuel-hawker,
PaulRMellor and
im-konge
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
fvaleri
force-pushed
the
bridge-metrics
branch
from
ed1bb17 to
92453ac
Compare
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
PaulRMellor
reviewed
Jan 8, 2025
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
|
@ppatierno and @PaulRMellor your comments should be addressed, but let me know if you have any other concern. It would also be good to get some more feedback from other maintainers. Thanks. |
im-konge
approved these changes
Jan 16, 2025
scholzj
reviewed
Jan 16, 2025
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
scholzj
reviewed
Jan 19, 2025
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
|
@scholzj I think I addressed all your comments, let me know what you think. Thanks. |
scholzj
approved these changes
Jan 21, 2025
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
katheris
reviewed
Jan 23, 2025
katheris
approved these changes
Jan 23, 2025
|
This proposal has now 6 +1 binding votes. I will leave this open until the end of today for further comments and then merge. |
Frawless
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proposal for integrating Bridge with Metrics Reporter.