Don't use a filter on isReady calls for Google Pay

[porter-stripe]

Summary

• For some reason when filtering out brands for Google Pay in the isReady call it can occassionally lead to unknown errors trying to launch Google Pay.
• To mitigate this we just don't filter cards for the isReady call, this has no impact on the actual payment request made, where we actually filter the card brands which works as expected.
• I was able to repro this issue and verify the fix.

Motivation

• Card brand filtering

Testing

• Manually tested
• Add a new unit test

Changelog

N/A

[github-actions]

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff  
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
      dex │   3.8 MiB │   3.8 MiB │ +420 B │   8.4 MiB │   8.4 MiB │ +40 B 
     arsc │   2.3 MiB │   2.3 MiB │    0 B │   2.3 MiB │   2.3 MiB │   0 B 
 manifest │     5 KiB │     5 KiB │    0 B │  24.9 KiB │  24.9 KiB │   0 B 
      res │ 902.2 KiB │ 902.2 KiB │    0 B │   1.4 MiB │   1.4 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │   0 B 
    asset │   1.6 MiB │   1.6 MiB │    0 B │   1.6 MiB │   1.6 MiB │   0 B 
    other │ 199.8 KiB │ 199.8 KiB │   -6 B │ 440.1 KiB │ 440.1 KiB │   0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
    total │  11.4 MiB │  11.4 MiB │ +414 B │  20.2 MiB │  20.2 MiB │ +40 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 39758 │ 39758 │ 0 (+1 -1) 
   types │ 13711 │ 13711 │ 0 (+0 -0) 
 classes │ 11403 │ 11403 │ 0 (+0 -0) 
 methods │ 58601 │ 58601 │ 0 (+1 -1) 
  fields │ 38901 │ 38901 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6189 │ 6189 │  0

APK

    compressed     │   uncompressed    │                                           
──────────┬────────┼───────────┬───────┤                                           
 size     │ diff   │ size      │ diff  │ path                                      
──────────┼────────┼───────────┼───────┼───────────────────────────────────────────
  3.8 MiB │ +420 B │   8.4 MiB │ +40 B │ ∆ classes.dex                             
   53 KiB │   -5 B │ 117.6 KiB │   0 B │ ∆ META-INF/CERT.SF                        
    272 B │   +2 B │     120 B │   0 B │ ∆ META-INF/version-control-info.textproto 
 49.7 KiB │   -2 B │ 117.5 KiB │   0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │   -1 B │   1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA                       
──────────┼────────┼───────────┼───────┼───────────────────────────────────────────
  3.9 MiB │ +414 B │   8.6 MiB │ +40 B │ (total)

DEX

STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   39758 │ 39758 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"5b6401d","r8-mode":"full","version":"8.7.14"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"bdb5a7e","r8-mode":"full","version":"8.7.14"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   58601 │ 58601 │ 0 (+1 -1) 
  
  + D4.k a(f, Boolean, boolean) → JSONObject
  
  - D4.k a(f, Boolean) → JSONObject

[jaynewstrom-stripe]

Thanks!