Track usage of raw_request
#1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
requested review from
a team and
pakrym-stripe
and removed request for
a team
|
Should we target master first and then merge the infrastructure change into beta? |
Yes. That's available now in #1780. |
pakrym-stripe
approved these changes
Dec 11, 2023
Usage telemetry infrastructure
richardm-stripe
force-pushed
the
richardm-usage
branch
from
863eac6 to
086f66c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
usagetoX-Stripe-Client-Telemetry, without breaking changes to the public interface.raw_requestin the beta branch.Details
Release
The first commit Usage infrastructure I intend to merge into master in a follow-up, after discussion.
The second commit Usage for raw_reuest is only applicable to the beta branch. I've opened the PR against beta showing both for a more holistic review.
Implementation
The tricky part about all this is: we have a struct
BackendImplementationwith publicDoandCallmethods (CallinvokesDo). Only theDomethod has access toParamswhich is where we want to putusage, but only theCallmethod has access toduration, which also needs to go on the telemetry header. The ideal solution would involve changing the signature ofDoso that it can shuffle the information back toCallin the return value, but that's breaking. To avoid a breaking change, what we instead have to do is pass this information through theLastResponseSetter.BackendImplementationalthough "public" is marked as internal and we say that public use is deprecated since 2018. Things would be much simpler if we broke it.It also turns out, there's not much code sharing in the RawRequest implementation right now, it doesn't go through
backend.Call, for instance.