Declare STPPaymentConfiguration shared property with let to prevent swift concurrency issue #3604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Declare
STPPaymentConfiguration
shared property withlet
to prevent swift concurrency error when enabling complete mode for strict concurrency checking in the project that uses this library.Motivation
Here's the error raised by the compiler on the declaration side
@objc(sharedConfiguration) public static var shared = STPPaymentConfiguration()
:Class property 'shared' is not concurrency-safe because it is non-isolated global shared mutable state; this is an error in Swift 6
.and here's the error on the use side of
STPPaymentConfiguration.shared
:Reference to class property 'shared' is not concurrency-safe because it involves shared mutable state; this is an error in Swift 6
Unfortunately, import Stripe using
@preconcurrency import
doesn't fix the issue.