Allowing [] input instead of '' in UpdateableAPIResource modify method #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I define a new function
_format_values
which looks through the entire params input of themodify
method and will change all final instances of [] to "" (empty string) so that the user can input [] to empty the list instead of having to input an empty string.This PR resolves issue #802
Please feel free to give feedback on the implementation/ any changes I could make to have this merged. I look forward to hearing feedback.
Thanks
Jordan