Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing [] input instead of '' in UpdateableAPIResource modify method #1018

Closed
wants to merge 1 commit into from

Conversation

JoJo10Smith
Copy link

I define a new function _format_values which looks through the entire params input of the modify method and will change all final instances of [] to "" (empty string) so that the user can input [] to empty the list instead of having to input an empty string.

This PR resolves issue #802

Please feel free to give feedback on the implementation/ any changes I could make to have this merged. I look forward to hearing feedback.
Thanks
Jordan

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2023

CLA assistant check
All committers have signed the CLA.

@anniel-stripe
Copy link
Contributor

Hi @JoJo10Smith, unfortunately we won't be accepting this PR at this time - this is a breaking change, as users who explicitly set a param to [] may have been relying, intentionally or not, on the library's no-op behavior. We're also unlikely to prioritize this change in the next major version, as we'd like to investigate this a bit more before applying a disruptive fix.

@JoJo10Smith
Copy link
Author

Got it, thank you for the explanation @anniel-stripe

@JoJo10Smith JoJo10Smith deleted the UpdateFormat branch September 21, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants