Artifact Archive Listing Implementation#1760
Artifact Archive Listing Implementation#1760anki2189 wants to merge 19 commits intostrongbox:issues/1649from
Conversation
| void setDownloadCount(Integer downloadCount); | ||
|
|
||
| ArtifactArchiveListing getArtifactArchiveListing(); | ||
| Set<ArtifactArchiveListing> getArtifactArchiveListings(); |
There was a problem hiding this comment.
@anki2189 we don't need ArtifactArchiveListing in Artifact.
There was a problem hiding this comment.
we should have Artifact reference from ArtifactArchiveListing instead.
|
|
||
| @Inject | ||
| GenericArtifactCoordinatesAdapter genericArtifactCoordinatesAdapter; | ||
|
|
There was a problem hiding this comment.
@anki2189 could you not add empty lines here and always.
There was a problem hiding this comment.
@sbespalov I am using the formatter available on strongbox-documentation page and these lines are getting generated by it.
There was a problem hiding this comment.
@carlspring do we need this empty lines in formatter?
There was a problem hiding this comment.
Yeah, having an empty line between fields is how the majority of the code currently looks like, so I would prefer that we follow this convention.
There was a problem hiding this comment.
@carlspring will it be possible to review this rule? these empty lines don't bring any sense but from the other side its absence means a lot on my 13 inch laptop :)
| .has("uuid", uuid) | ||
| .as("artifact"); | ||
|
|
||
| artifactArchiveListings.stream() |
There was a problem hiding this comment.
@sbespalov Please help me to figure out why this is not adding Edge to graph.
sbespalov
force-pushed
the
issues/1649
branch
from
cd88509 to
53125c1
Compare
sbespalov
force-pushed
the
issues/1649
branch
from
90adcc2 to
bd7bc73
Compare
sbespalov
force-pushed
the
issues/1649
branch
from
bd7bc73 to
8313414
Compare
sbespalov
force-pushed
the
issues/1649
branch
from
5a76d0f to
e4fa368
Compare
3 participants
Pull Request Description
This pull request closes #1752
Acceptance Test
mvn clean install -Dintegration.testsstill works.mvn spring-boot:runin thestrongbox-web-corestill starts up the application correctly.strongbox-distributionfrom aziportar.gzstill works.strongbox-web-integration-testsstill run properly.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?