build: overhaul build with vite & playwright#2825
Merged
hugo-vrijswijk merged 2 commits intomasterfrom Nov 16, 2023
Merged
Conversation
Member
|
This improvement is freakin' amazing 🤩! I haven't had time to look at it yet, but I will try to do it in a 1h train ride later today. |
nicojs
reviewed
Nov 7, 2023
fad8134 to
ae28d1d
Compare
nicojs
requested changes
Nov 13, 2023
Member
There was a problem hiding this comment.
We've looked through the code together. 🤝 Some findings:
- Vite is now responsible for bundling each project. Only elements should be bundled. We should use plain
tsc --buildlike before. - It's OK to have a breaking change to move to
esm. I didn't even realize this project was not ESM yet. - Dev experience:
- We should have an up-to-date CONTRIBUTING.md, including a cheat sheet.
- Some commands should work from the root. Useful ones might be:
testandbuild? - CTRL+SHIFT+B support and debugging (launch.json) should be updated
3c85cf1 to
5038a5d
Compare
nicojs
approved these changes
Nov 16, 2023
Member
There was a problem hiding this comment.
This looks a lot better :). Just a few remarks:
- The task "Debug Unit Tests (elements)" is not working. How do we debug elements unit tests?
- The breaking change of not exporting
MutantStatusanymore will hurt a bit in StrykerJS, as we use it all over the place (it was the only way to work with the mutant result). But I see why it is necessary. - How does one debug the playwright tests? I see the playwright plugin is added to the recommended plugins, can I use that? Maybe we can add this to the CONTRIBUTING.md?
I've updated the schema2ts script, so pull before changing anything else.
252de1a to
b721dc4
Compare
BREAKING CHANGE: mutation-testing-report-schema and mutation-testing-metrics are now ESM BREAKING CHANGE: report-schema `MutantStatus` is a union type instead of TS enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhauls the build (and tests) by setting up Vite to build all projects, and playwright for the elements integration tests.
BREAKING CHANGE: mutation-testing-report-schema and mutation-testing-metrics are now ESM
BREAKING CHANGE: report-schema
MutantStatusis a union type instead of TS enum