Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StudentQuiz: The marker bullets are overlapping #787208 #491

Merged
merged 1 commit into from
May 21, 2024

Conversation

danghieu1407
Copy link
Contributor

with the placeholder text in the comment textbox

Hi @timhunt,
This ticket is ready for review.
I have created a new function, setPlaceholder, to set a placeholder when the editor is empty.
I have also added a new condition for the mutation. Previously, when we reloaded the page and then inserted a line break using "Enter", if we deleted the line break and pressed "Space", the mutation would not trigger. To address this, I added a new condition.
Additionally, I have created a regex to handle specific cases. If it matches, it means the data in the editor is empty.
Could you please review these changes? Many thanks.

with the placeholder text in the comment textbox
@timhunt
Copy link
Member

timhunt commented May 21, 2024

Note for future reference: element.dataset.placeholder = placeholder is better than element.attr('data-placeholder', placeholder).

But, I will merge this as is, because the code is consistently using the less good style.

@timhunt timhunt merged commit 3c2ae9b into studentquiz:main May 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants