This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Add unix domain socket support for the RPCClient.#20
Open
a-sk wants to merge 1 commit intostudio-ousia:masterfrom
Open
Add unix domain socket support for the RPCClient.#20a-sk wants to merge 1 commit intostudio-ousia:masterfrom
a-sk wants to merge 1 commit intostudio-ousia:masterfrom
Conversation
To not break backwards compatibility this commit makes host and port optional and None by default and adds unix_socket_path argument. Now it is possible to provide either host and port or path to a unix domain socket. If one of those arguments are missing, AssertionError will be raised.
|
This would be really nice. Any change of movement on this? |
|
What would be required to merge this? Fixing the conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To not break backwards compatibility this commit makes host and port
optional and None by default and adds unix_socket_path argument.
Now it is possible to provide either host and port or path to a unix
domain socket. If one of those arguments are missing, AssertionError
will be raised.