Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.0 #43

Merged
merged 27 commits into from
Dec 30, 2023

#43 Refactoring Codacy Issue

f7b6bd9
Select commit
Loading
Failed to load commit list.
Merged

v0.5.0 #43

#43 Refactoring Codacy Issue
f7b6bd9
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Dec 29, 2023 in 0s

9 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 4
- Added 9
           

Coverage increased per file
===========================
+ src/EduFramework/Core/Service/DatabaseMysql.php  100.0
+ src/EduFramework/Core/Service/DatabaseService.php  50.0
         

Complexity increasing per file
==============================
- src/EduFramework/Core/Controller/Error/HttpErrorDefaultController.php  1
- src/EduFramework/Core/View/StudooDebugExtension.php  1
- app/Controller/DataBaseTestController.php  1

See the complete overview on Codacy

Annotations

Check failure on line 59 in src/EduFramework/Core/ConfigCore.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/ConfigCore.php#L59 

Direct use of $_ENV Superglobal detected.

Check notice on line 30 in src/EduFramework/Core/Service/DatabaseMysql.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/Service/DatabaseMysql.php#L30 

Array key not aligned correctly; expected 13 spaces but found 16

Check notice on line 31 in src/EduFramework/Core/Service/DatabaseMysql.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/Service/DatabaseMysql.php#L31 

Array double arrow not aligned correctly; expected 1 space(s) but found 3

Check notice on line 37 in src/EduFramework/Core/View/StudooDebugExtension.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/View/StudooDebugExtension.php#L37 

Comment refers to a TODO task "Changer le style de l'affichage"

Check notice on line 39 in src/EduFramework/Core/View/StudooDebugExtension.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/View/StudooDebugExtension.php#L39 

Avoid using short method names like StudooDebugExtension::dd(). The configured minimum method name length is 3.

Check warning on line 42 in src/EduFramework/Core/View/StudooDebugExtension.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/View/StudooDebugExtension.php#L42 

The use of function var_dump() is discouraged

Check failure on line 45 in src/EduFramework/Core/View/StudooDebugExtension.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/View/StudooDebugExtension.php#L45 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '"<div style=\"background-color: grey; color: white; padding: 10px; margin: 10px 0;\">
'.

Check failure on line 45 in src/EduFramework/Core/View/StudooDebugExtension.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/View/StudooDebugExtension.php#L45 

Use of echo language construct is discouraged.

Check notice on line 40 in src/EduFramework/Core/View/TwigCore.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/EduFramework/Core/View/TwigCore.php#L40 

Array with multiple values cannot be declared on a single line
View more details on Codacy Production