[Chore] PR의 title 포맷을 검사하는 action workflow 작성, 깃 pre-push 훅 수정#10
[Chore] PR의 title 포맷을 검사하는 action workflow 작성, 깃 pre-push 훅 수정#10
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Improper Error Stream Usage ▹ view | ✅ Fix detected |
 |
Non-localized configuration message ▹ view | ✅ Fix detected |
 |
Incorrect comment for exit status ▹ view | ✅ Fix detected |
 |
Inefficient String Pattern Matching ▹ view | ✅ Fix detected |
|
Incomplete Commit Types ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| commitlint.config.js | ✅ |
| src/scripts/build.sh | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
commitlint.config.js
Outdated
| 'header-pattern': [ | ||
| 2, | ||
| 'always', | ||
| /^\[(Feature|Fix|Chore|Docs|Style|Refactor|Test)\] .+(?: \(#\d+\))?$/, |
There was a problem hiding this comment.
Incomplete Commit Types 
Tell me more
What is the issue?
The commit message pattern does not include common types like 'Perf' (Performance) and 'Breaking' (Breaking Changes), which are standard in conventional commits.
Why this matters
Missing commit types will prevent developers from properly categorizing performance improvements and breaking changes, making it harder to generate accurate changelogs and manage semantic versioning.
Suggested change ∙ Feature Preview
Add additional standard commit types to the pattern:
/^\[(Feature|Fix|Chore|Docs|Style|Refactor|Test|Perf|Breaking)\] .+(?:\s\(#\d+\))?$/Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
commitlint.config.js
Outdated
| 'header-pattern-message': [ | ||
| 2, | ||
| 'always', | ||
| '커밋 메시지는 [Type] 제목 (#이슈번호)? 형태여야 합니다.', |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
All of our team members are Korean, and there is no possibility of non-Korean team members joining.
There was a problem hiding this comment.
네, 팀 구성을 고려했을 때 한글 메시지가 더 적절해 보입니다. 현재 구성을 유지하시면 될 것 같습니다.
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Incomplete Shell Safety Options ▹ view | 🧠 Incorrect |
Files scanned
| File Path | Reviewed |
|---|---|
| src/scripts/start-dev.sh | ✅ |
| src/scripts/generate-cert.sh | ✅ |
| src/scripts/build.sh | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| @@ -1,22 +1,35 @@ | |||
| #!/bin/sh | |||
| set -e | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
As I know, pipefail is a bash-only construct. Am I right?
There was a problem hiding this comment.
Yes, you're correct. set -o pipefail is a bash-specific feature and won't work with /bin/sh. For sh compatibility, we should stick with just set -eu. Alternatively, if pipefail is needed, we could change the shebang to #!/bin/bash.
- feat: XXX -> feat!: XXX
dioo1461
changed the title
1 participant
✨ 구현 기능 명세
/.github/workflows/pr-title-lint.yaml)npm run android:build스크립트가 제대로 실행되지 않던 문제가 있었습니다. 이를 해결했습니다.✅ PR Point
😭 어려웠던 점
Description by Korbit AI
What change is being made?
Add a GitHub Action workflow to enforce PR title format compliance and update pre-push hook to utilize stricter error handling.
Why are these changes being made?
Ensuring PR titles follow a consistent format improves readability and maintainability across the project. The use of
-euo pipefailin pre-push hooks enhances error detection by ensuring that scripts fail on uninitialized variables and that command pipeline errors are reported properly.