Open
Conversation
p-senichenkov
approved these changes
Dec 13, 2025
6/main_sorted_list.c
Outdated
| while (inp != '0') { | ||
| int value; | ||
| switch (inp) { | ||
| case '1': |
There was a problem hiding this comment.
По стайлгайду switch формтируется не так. И ширина отступа -- 4 пробела.
6/sorted_list.c
Outdated
Comment on lines
13
to
15
| Node* node = malloc(sizeof(Node)); | ||
| (*node).next = NULL; | ||
| (*node).value = value; |
There was a problem hiding this comment.
Можно эти три строчки, вместе с проверкой корректности выделения памяти вынести в отдельную функцию. Абстрактный тип данных должен сам себя уметь инициализировать.
6/sorted_list.c
Outdated
| Node* buff = NULL; | ||
|
|
||
|
|
||
| while (current < value) { |
There was a problem hiding this comment.
Suggested change
| while (current < value) { | |
| while (head->value < value) { |
6/sorted_list.c
Outdated
Comment on lines
71
to
73
| if ((*head).next == NULL) { | ||
|
|
||
| } |
6/sorted_list.c
Outdated
|
|
||
|
|
||
| void removeValue(List* list, int value) { | ||
| Node* head = (*list).head; |
There was a problem hiding this comment.
Не очень хорошо эту переменную называть head. Она head только в самом начале. А так это просто текущая просматриваемая вершина, например, current, или temp, или iter.
p-senichenkov
suggested changes
Dec 25, 2025
Comment on lines
+77
to
+83
| if (buff != NULL) { | ||
| (*buff).next = (*iter).next; | ||
| } | ||
|
|
||
| else { | ||
| (*list).head = (*iter).next; | ||
| } |
There was a problem hiding this comment.
Форматирование должно быть не такое
| return node; | ||
| } | ||
|
|
||
| void addValue(List* list, int value) |
There was a problem hiding this comment.
Кажется, эту функцию можно сделать короче. И removeValue тоже.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.