Dev #2
Dev #2
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function sharePrice() external view returns (uint) { | ||
| uint units = 10 ** uint(decimals()); | ||
| uint totalSupply_ = totalSupply(); | ||
| return totalSupply_ == 0 ? units : units * totalAssets() / totalSupply_; | ||
| } |
Check warning
Code scanning / Slither
Dangerous strict equalities Medium
| IERC20(asset).approve(gauge_, type(uint).max); | ||
| address _gaugeRewardToken = IPearlGaugeV2(gauge_).rewardToken(); |
Check notice
Code scanning / Slither
Missing zero address validation Low
| function sharePrice() external view returns (uint) { | ||
| uint units = 10 ** uint(decimals()); | ||
| uint totalSupply_ = totalSupply(); | ||
| return totalSupply_ == 0 ? units : units * totalAssets() / totalSupply_; | ||
| } |
Check warning
Code scanning / Slither
Dangerous strict equalities Medium
|
|
||
| constructor(address governance_) { | ||
| require(governance_ != address(0), "WRONG_INPUT"); | ||
| governance = governance_; | ||
| _operators.add(governance_); | ||
| } | ||
|
|
||
| function setup(address ifo_, address ve_, address stgn_, address multigauge_) external { | ||
| function setup(address ifo_, address ve_, address stgn_, address multigauge_, address liquidator_) external { |
Check notice
Code scanning / Slither
Missing zero address validation Low
| @@ -0,0 +1,119 @@ | |||
| // SPDX-License-Identifier: BUSL-1.1 | |||
| pragma solidity ^0.8.21; | |||
Check warning
Code scanning / Slither
Incorrect versions of Solidity Warning
| @@ -0,0 +1,26 @@ | |||
| // SPDX-License-Identifier: BUSL-1.1 | |||
| pragma solidity ^0.8.21; | |||
Check warning
Code scanning / Slither
Incorrect versions of Solidity Warning
| event VeTokenLocked(address indexed stakingToken, address indexed account, uint tokenId); | ||
| event VeTokenUnlocked(address indexed stakingToken, address indexed account, uint tokenId); | ||
|
|
||
| // ************************************************************* | ||
| // INIT | ||
| // ************************************************************* | ||
|
|
||
| function init(address controller_, address _ve, address _defaultRewardToken) external initializer { | ||
| function init(address controller_, address _defaultRewardToken) external initializer { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| // todo Compounder CVR | ||
| address _compounder = compounder; | ||
| ITetuLiquidator l = ITetuLiquidator(controller.liquidator()); | ||
| address asset = IERC4626(_compounder).asset(); |
Check notice
Code scanning / Slither
Local variable shadowing Low
|
|
||
| address public compounder; | ||
|
|
||
| constructor(address vault_, address gauge_, bool ifo_, address compounder_) StrategyStrictBase(vault_) { |
Check notice
Code scanning / Slither
Missing zero address validation Low
|
|
||
| address public compounder; | ||
|
|
||
| constructor(address vault_, address gauge_, bool ifo_, address compounder_) StrategyStrictBase(vault_) { |
Check notice
Code scanning / Slither
Missing zero address validation Low
| } else { | ||
| // todo Compounder CVR | ||
| address _compounder = compounder; |
Check warning
Code scanning / Slither
Variable names too similar Warning
No description provided.