-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make action more modular, improve security and docs #1
base: main
Are you sure you want to change the base?
Conversation
devgioele
commented
Aug 11, 2022
- Use GPG instead of OpenSSL without IV
- Let users decide when to download or upload the state, like already suggested at V2 of this repo
- Update integration testing to fit changes
Of course, all links currently refer to my repo. To do if these changes are accepted:
|
Hey @devgioele thanks for your PR ❤️ Very happy that someone found my experiment interesting. Sorry for the late reply I've been away and I wont have time for proper feedback for the next couple of days either. At a quick glance everything looks good though. A side-note; a caveat i discovered the other day which made me question keeping this action or adding yet another disclaimer. If no commit is made to the repository for some time it will disable workflows despite cron schedules, potentially causing the destruction of the statefile artifact. Some potential workarounds are creating dummy commits etc... https://stackoverflow.com/questions/67184368/prevent-scheduled-github-actions-from-becoming-disabled. Food for thought. I'll try to get to the PR review ASAP. Thanks! |
That's unfortunate. I honestly don't like the idea of dummy commits. It shows that artifacts are not meant for permanent storage. I would just add it as a side-note. This solution is kind of a hack anyway. Sorry for the late reply. |