-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Aero-Structural Discrete Adjoint Sensitivities and Python Wrapper Developments #1750
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
CPreconditioner<Scalar>* PrimalPreconditioner = nullptr; | ||
CSysMatrixVectorProduct<Scalar>* PrimalJacobian = nullptr; | ||
|
||
class LinOperator : public CMatrixVectorProduct<Scalar> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new compiler warning is generated...
[738/745] Generating 'SU2_PY/pySU2/_pysu2.so.p/pySU2.cxx'.
../SU2_PY/pySU2/../../SU2_CFD/include/drivers/CDiscAdjSinglezoneDriver.hpp:91: Warning 325: Nested class not currently supported (LinOperator ignored)
../SU2_PY/pySU2/../../SU2_CFD/include/drivers/CDiscAdjSinglezoneDriver.hpp:102: Warning 325: Nested class not currently supported (LinPreconditioner ignored)
[744/745] Installing files.
} | ||
|
||
CopiedJacobian.TransposeInPlace(); | ||
PrimalJacobian = new CSysMatrixVectorProduct<Scalar>(CopiedJacobian, geometry, config); |
Check warning
Code scanning / CodeQL
Resource not released in destructor
All the regression and unit tests are passing now! |
The following functions in Adjoints
Sensitivities
Flow solution
|
Hi, are there any updates on this feature? Or maybe some simple example? |
dr. @patelha57 what is the status of this PR? Do you still have time to finalize it? Would be nice to have it, there's a lot of work that you've put into it. |
Hi, Nijso! You're absolutely right and that's my bad for slacking. The PR requires some finishing touches (mainly adoption of CPyWrapperMatrixView for some methods) and bug fixes until the regression tests are passing. I will find time to finalize it over the holidays |
Motivation
Fundamental bottlenecks exist for industrial adoption of high-fidelity physics codes with fully coupled discrete adjoint sensitivity analysis. These bottlenecks include a lack of flexibility, modularity, and robustness of the computational tools, as well as the potential startup development costs needed to implement and verify the MDAO features. The purpose of this work is to facilitate the coupling of SU2 with external structural codes (e.g. NASTRAN, TACS, Airbus structural suite Lagrange) for gradient-based aerodynamic shape and structural sizing optimization using dedicated frameworks (e.g. OpenMDAO).
Startup development costs include the creation of modular tools that are designed to be driven by another framework like OpenMDAO, rather than to drive execution themselves. However, leveraging those MDAO frameworks assumes that software codes and modules to be coupled exist, have appropriate data structures, execution and query APIs, and are wrapped in Python for flexibility and ease of use. The proposed changes were motivated with the goal of making SU2 more modular and flexible, particularly to facilitate its integration into large-scale MDAO frameworks. For more details on the motivation, methodology, and verification & validation results, please refer to our paper from AIAA Aviation 2022.
Proposed Changes
@aa-g and I propose the following code updates:
Implementation of residual-based discrete adjoint solver as
CDiscAdjResidualSolver
a. New config option:
KIND_DISC_ADJ
Enhancements and standardization of SU2 Python API
a. Add pysu2/pysu2ad methods
b. Standardize Python API and function names
c. Overloaded getter/setter methods to make data handling more flexible
Related Work
These efforts are related to Issue #1262, Pull Request #1300, and Discussion #1325.
PR Checklist