Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write compact restart files #2372

Merged
merged 59 commits into from
Jan 2, 2025
Merged

Write compact restart files #2372

merged 59 commits into from
Jan 2, 2025

Conversation

bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Oct 31, 2024

Proposed Changes

We aim to implement 2 things:

  1. Restart files contain variables that are not necessary for restarts. with the keyword WRT_RESTART_COMPACT= YES we can write compact restart files containing only necessary fields.
  2. Other output contains variables that are not requested (all SOLUTION variables are always written). When using VOLUME_OUTPUT=COMPACT, we do not automatically write the SOLUTION fields to e.g. paraview.
  3. additionally, we write compact surface .csv files.

Related Work

Mentioned in Issue (request) #2118

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the title [WIP] Write compact restart files Write compact restart files Nov 6, 2024
SU2_CFD/src/output/COutput.cpp Fixed Show fixed Hide fixed
SU2_CFD/src/output/COutput.cpp Fixed Show fixed Hide fixed
@bigfooted bigfooted changed the title Write compact restart files [WIP] Write compact restart files Nov 20, 2024
bigfooted and others added 3 commits November 20, 2024 23:02
…type in loop condition

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@bigfooted bigfooted changed the title [WIP] Write compact restart files Write compact restart files Nov 21, 2024
SU2_CFD/src/output/COutput.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/output/COutput.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/output/COutput.cpp Outdated Show resolved Hide resolved
Common/src/CConfig.cpp Outdated Show resolved Hide resolved
config_template.cfg Outdated Show resolved Hide resolved
SU2_CFD/include/output/filewriter/CParallelDataSorter.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/output/COutput.hpp Outdated Show resolved Hide resolved
SU2_CFD/src/output/COutput.cpp Outdated Show resolved Hide resolved
bigfooted and others added 4 commits November 25, 2024 08:00
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
@bigfooted
Copy link
Contributor Author

Not sure yet why the stl file writing is failing. It is just SU2_SOL writing an stl, no solution is involved.

@bigfooted
Copy link
Contributor Author

The stl file writing (rans/oneram6) is working fine on my machine and produces the same stl as the regression result. I'll see if I can get it to fail inside a docker later.

@pcarruscag pcarruscag merged commit f4cda52 into develop Jan 2, 2025
34 of 35 checks passed
@pcarruscag pcarruscag deleted the feature_small_restart branch January 2, 2025 03:58
@bigfooted
Copy link
Contributor Author

thanks, Pedro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants