Update turbo ramps #2419

joshkellyjak · 2025-01-13T16:07:35Z

Proposed Changes

The turbomachinery ramps were missing the option to ramp the translation rate in 2D and the ability to ramp the outlet mass flow, these have been added and the function has been made more general to accomodate these additions. It should be much easier to add ramps in the future.

Related Work

N/A

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

SU2_CFD/src/iteration/CTurboIteration.cpp

…dded CodeQL comments

SU2_CFD/src/iteration/CTurboIteration.cpp

pcarruscag

Nice, just some minor stuff and it's good to go.

pcarruscag · 2025-01-19T19:51:25Z

AUTHORS.md

@@ -96,6 +96,7 @@ Johannes Blühdorn
 JonathanSmith1936
 Joseph Signorelli
 Josy P. Pullockara
+Joshua A. Kelly


H is before Y

Spelling my own name is a challenge on occasion

pcarruscag · 2025-01-19T20:03:08Z

Common/include/CConfig.hpp

+  /*!
+   * \brief Get the final translation velocity of the mesh in the y-direction
+   * \return Velocity of the mesh in the y-direction
+   */
+  su2double GetFinalTranslation_Rate_Y() const { return FinalTranslation_Rate_Y;}
+


Can this be removed now? And maybe some of the older functions to set/get Z rotation?

pcarruscag · 2025-01-19T20:03:50Z

Common/include/option_structure.hpp

@@ -1886,6 +1886,17 @@ enum TURBO_MARKER_TYPE{
  OUTFLOW = 2     /*!< \brief flag for outflow marker for compute turboperformance. */
 };

+enum TURBO_RAMP_TYPE{


Suggested change

enum TURBO_RAMP_TYPE{

enum class TURBO_RAMP_TYPE{

pcarruscag · 2025-01-19T20:04:17Z

Common/include/option_structure.hpp

+  GRID = 1,       /*!< \brief flag for rotational/translational ramps */
+  BOUNDARY = 2    /*!< \brief flag for pressure/mass flow ramps*/


Suggested change

GRID = 1, /*!< \brief flag for rotational/translational ramps */

BOUNDARY = 2 /*!< \brief flag for pressure/mass flow ramps*/

GRID, /*!< \brief flag for rotational/translational ramps */

BOUNDARY /*!< \brief flag for pressure/mass flow ramps*/

pcarruscag · 2025-01-19T20:04:32Z

Common/include/option_structure.hpp

+enum TURBO_RAMP_COEFF{
+  INITIAL_VALUE = 0,  /*!< \brief intial value of the ramp */
+  UPDATE_FREQ = 1,    /*<! \brief update frequency of the ramp */
+  FINAL_ITER = 2     /*<! \brief final iteration of the ramp */


Suggested change

FINAL_ITER = 2 /*<! \brief final iteration of the ramp */

FINAL_ITER = 2 /*<! \brief final iteration of the ramp */

pcarruscag · 2025-01-19T20:05:24Z

Common/include/option_structure.hpp

+  BOUNDARY = 2    /*!< \brief flag for pressure/mass flow ramps*/
+};
+
+enum TURBO_RAMP_COEFF{


Document that these are used to access the entries in the coefficient ramps and thus are numbered in a particular way.

pcarruscag · 2025-01-19T20:05:59Z

Common/src/CConfig.cpp

@@ -4355,25 +4355,55 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i
    nSpan_iZones = new unsigned short[nZone];
  }

+  /*--- Interface for handling turbo ramps ---*/
+  if(GetGrid_Movement() && RampMotionFrame && !DiscreteAdjoint){


Consistency please

Suggested change

if(GetGrid_Movement() && RampMotionFrame && !DiscreteAdjoint){

if (GetGrid_Movement() && RampMotionFrame && !DiscreteAdjoint) {

pcarruscag · 2025-01-19T20:06:48Z

Common/src/CConfig.cpp

+
+  if(RampOutlet && !DiscreteAdjoint) {
+    for (iMarker = 0; iMarker < nMarker_Giles; iMarker++){
+      if (Kind_Data_Giles[iMarker] == STATIC_PRESSURE ||  Kind_Data_Giles[iMarker] == STATIC_PRESSURE_1D || Kind_Data_Giles[iMarker] == RADIAL_EQUILIBRIUM )


Suggested change

if (Kind_Data_Giles[iMarker] == STATIC_PRESSURE || Kind_Data_Giles[iMarker] == STATIC_PRESSURE_1D || Kind_Data_Giles[iMarker] == RADIAL_EQUILIBRIUM )

switch (Kind_Data_Giles[iMarker]) {

pcarruscag · 2025-01-19T20:08:22Z

SU2_CFD/src/iteration/CTurboIteration.cpp

+    const long unsigned rampFreq = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, TURBO_RAMP_COEFF::UPDATE_FREQ));
+    const long unsigned finalRamp_Iter = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, TURBO_RAMP_COEFF::FINAL_ITER));


Any reason why you can't auto these?

Suggested change

const long unsigned rampFreq = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, TURBO_RAMP_COEFF::UPDATE_FREQ));

const long unsigned finalRamp_Iter = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, TURBO_RAMP_COEFF::FINAL_ITER));

const unsigned long rampFreq = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, TURBO_RAMP_COEFF::UPDATE_FREQ));

const unsigned long finalRamp_Iter = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, TURBO_RAMP_COEFF::FINAL_ITER));

pcarruscag · 2025-01-19T20:10:59Z

Common/src/CConfig.cpp

-  /*!\brief RAMP_OUTLET_PRESSURE\n DESCRIPTION: option to ramp up or down the rotating frame velocity value*/
-  addBoolOption("RAMP_OUTLET_PRESSURE", RampOutletPressure, false);
-  rampOutPres_coeff[0] = 100000.0; rampOutPres_coeff[1] = 1.0; rampOutPres_coeff[2] = 1000.0;
-  /*!\brief RAMP_OUTLET_PRESSURE_COEFF \n DESCRIPTION: the 1st coeff is the staring outlet pressure,


Add entries to the deprecated options so that users with old configs are pointed to the new option.

joshkellyjak added 2 commits January 13, 2025 16:02

Added extra turbo ramp options, generalised function

2b74501

Update documentation

e7cb52b

joshkellyjak added the changelog:feature label Jan 13, 2025

joshkellyjak added 3 commits January 13, 2025 16:26

Resolve compilation error and minor bug

f4b65fc

Incorrect type conversion

5c40247

Compilation warning fix

6d4fa45

joshkellyjak added the PR: draft label Jan 13, 2025

joshkellyjak changed the title ~~Update turbo ramps~~ [WIP] Update turbo ramps Jan 13, 2025

github-advanced-security bot found potential problems Jan 13, 2025

View reviewed changes

SU2_CFD/src/iteration/CTurboIteration.cpp Fixed Show fixed Hide fixed

joshkellyjak and others added 3 commits January 16, 2025 15:01

Slight bug

03aefd6

Added catch for if update freq is not a factor of final ramp iter & a…

12d2bc0

…dded CodeQL comments

Merge branch 'develop' into feature_turbo_ramps

543e062

joshkellyjak changed the title ~~[WIP] Update turbo ramps~~ Update turbo ramps Jan 16, 2025

pcarruscag reviewed Jan 17, 2025

View reviewed changes

SU2_CFD/src/iteration/CTurboIteration.cpp Outdated Show resolved Hide resolved

pcarruscag reviewed Jan 17, 2025

View reviewed changes

joshkellyjak added 3 commits January 17, 2025 15:27

Changes for comments w/ update docs & reg test configs

583f249

clang-format

92cf538

A slightly overdue modification

56f7c8a

pcarruscag reviewed Jan 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update turbo ramps #2419

Update turbo ramps #2419

joshkellyjak commented Jan 13, 2025

pcarruscag left a comment

pcarruscag Jan 19, 2025

joshkellyjak Jan 19, 2025

pcarruscag Jan 19, 2025

pcarruscag Jan 19, 2025

pcarruscag Jan 19, 2025

pcarruscag Jan 19, 2025

pcarruscag Jan 19, 2025

pcarruscag Jan 19, 2025

pcarruscag Jan 19, 2025

pcarruscag Jan 19, 2025

pcarruscag Jan 19, 2025

		GRID = 1, /!< \brief flag for rotational/translational ramps /
		BOUNDARY = 2 /!< \brief flag for pressure/mass flow ramps/

	FINAL_ITER = 2 /<! \brief final iteration of the ramp /
	FINAL_ITER = 2 /<! \brief final iteration of the ramp /

	if(GetGrid_Movement() && RampMotionFrame && !DiscreteAdjoint){
	if (GetGrid_Movement() && RampMotionFrame && !DiscreteAdjoint) {

	if (Kind_Data_Giles[iMarker] == STATIC_PRESSURE \|\| Kind_Data_Giles[iMarker] == STATIC_PRESSURE_1D \|\| Kind_Data_Giles[iMarker] == RADIAL_EQUILIBRIUM )
	switch (Kind_Data_Giles[iMarker]) {

		const long unsigned rampFreq = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, TURBO_RAMP_COEFF::UPDATE_FREQ));
		const long unsigned finalRamp_Iter = SU2_TYPE::Int(config->GetRamp_Coeff(ramp_flag, TURBO_RAMP_COEFF::FINAL_ITER));

Update turbo ramps #2419

Are you sure you want to change the base?

Update turbo ramps #2419

Conversation

joshkellyjak commented Jan 13, 2025

Proposed Changes

Related Work

PR Checklist

pcarruscag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment