-
Notifications
You must be signed in to change notification settings - Fork 877
Fix preaccumulation error, improve recording of RANS solvers #2472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@oleburghardt if everything is addressed can you resolve the conversations and merge please? |
Sure. CodeFactor is complaining about CSolver.hpp (complex code) which I've touched in a commit but which eventually remains unchanged. Forgot to ask during last dev meeting how we should handle it? |
You can ignore that warning, It doesn't say what to do so we can't do anything. |
Proposed Changes
This contributes two algorithmic-differentiation-based fixes;
SetRoe_Dissipation_FD
. This may change derivatives as the current recording of this function is likely to be wrong ifPREACC = YES
.muT
(eddy viscosity) as input/output to the recording of RANS solvers. Since both muT and conservative variables go "on the same level" into the flow solver'sPreprocessing
(i.e. we cannot think of muT as a derived value from the conservative ones), this should be reflected in the recording. (Also, the debug mode developed in Tape recording debug mode #2442 will complain otherwise ;-)).This change does not affect derivative values – especially it does nothing about the circumstance that Preprocessing is based on an initial value of muT, whereas the flow solvers depend on an updated one – but it may clarify things and remove a source of future problems.
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.