New Models Fixes #60
Merged
New Models Fixes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacoNelos
approved these changes
Dec 4, 2023
| @@ -134,13 +134,14 @@ def get_record( | |||
|
|
|||
| def create_policy( | |||
| self, policy: Policy, expected_statuses: Optional[list[int]] = None | |||
| ) -> None: | |||
| ) -> dict[str, str]: | |||
There was a problem hiding this comment.
very nitpicky, but fyi .json() returns Any, not dict (same for json.loads)
subroseio
added a commit
that referenced
this pull request
Dec 4, 2023
* WIP: Models refactor * More models * New Models Fixes (#60) * tests passing * tidy mods * validations on username * more validations * change to actor --------- Co-authored-by: Paco Nelos <nelospaco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing all tests