Require addresses to pass the built-in EMAIL_REGEXP

substancelab · Mar 27, 2024 · 25c9f96 · 25c9f96
1 parent 132704e
commit 25c9f96
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/activemodel_email_address_validator/email_address.rb b/lib/activemodel_email_address_validator/email_address.rb
@@ -33,7 +33,8 @@ def valid_using_regex?(regex)
     end
 
     def valid_using_default?
-      return false if /(\s|["'<>])+/.match?(address)
+      return false if /(\s|["'<>,])+/.match?(address)
+      return false unless URI::MailTo::EMAIL_REGEXP.match?(address)
 
       email_parts = address.split("@", -1)
       return false unless email_parts.size == 2

diff --git a/test/activemodel-email_address_validator/test_email_address.rb b/test/activemodel-email_address_validator/test_email_address.rb
@@ -136,6 +136,10 @@ def test_rejects_username_with_quotation_mark
     reject("email123@exa'mple.com")
   end
 
+  def test_rejects_unmailable_usernames
+    reject("abdalah291]79@example.com")
+  end
+
   private
 
   def accept(email_address)