chore: remove type of date/time attribute from test #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same weird download error as in #48 ... |
dshaaban01
force-pushed
the
dalia/fixes/literal-test
branch
from
ba124a2 to
540aed0
Compare
ingomueller-net
approved these changes
Feb 7, 2025
test/Dialect/Substrait/literal.mlir
Outdated
| @@ -16,7 +16,7 @@ substrait.plan version 0 : 42 : 1 { | |||
| %0 = named_table @t1 as ["a"] : tuple<si1> | |||
| %1 = project %0 : tuple<si1> -> tuple<si1, !substrait.time> { | |||
| ^bb0(%arg : tuple<si1>): | |||
| %time = literal #substrait.time<200000000us> : !substrait.time | |||
| %time = literal #substrait.time<200000000us> | |||
There was a problem hiding this comment.
Ultra nit: remove the trailing whitespaces please.
Suggested change
| %time = literal #substrait.time<200000000us> | |
| %time = literal #substrait.time<200000000us> |
ingomueller-net
approved these changes
Feb 17, 2025
|
Remember that #74 updated LLVM. I think it'd be best to rebase your PRs to main such that (1) we don't thrash the |
|
I rebased locally in my machine and ran the tests, so need to rebase this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed types of date/time attributes from the literal test and Export/literal tests to align with the timestamp tests. I noticed that these attributes were still present in date/time but not in timestamp tests - was this an oversight or intentional? Let me know if they were intentionally kept and will close the PR.