-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve content editing features, enable preview and SEO #59
Conversation
- created pills for 2 authors and 3+ authors; - moved Author pills to a single file located in Authors/AuthorPills; - fixed imports
- make header correspond to page type, changing background and font colors based on the type of page it is inserted instead of being generic
- changed metadata generation, badges, favicons and open graphs, replacing payload boilerplate open graph and use content tailored to the content-sub project
- enabled payload SEO plugin to automatically generate metadata for sharing; - enabled live preview and increased draft saving to facilitate previewing; - enabled page preview;
plugin was throwing errors upon type generation due to having collections parameters enabled, which isn't necessary for the current version.
and remove unused ones
- remake author pill as a standalone component; - use conditional rendering to make it fit one, two or more contributors;
<div key={i} className={styles.contentCard}> | ||
<ContentCard contentType={key} content={contentPiece} /> | ||
</div> | ||
<ContentCard contentType={key} content={contentPiece} rounded={true}/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When passing boolean = true props to components, you can use shorthand, just
<ContentCard {...other stuff} rounded />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted!
))} | ||
)} | ||
|
||
{socials.x.length === 1 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these arrays? Can users have multiple versions of each Social profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Deploy Preview for content-sub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…rs/improve-content-editing
- remove unused seed functionality; - add information about important features of the dashboard; - link to quick tutorial rundown;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more than I can review really, but let's go
Why:
Author
slug
field not populating automatically (issue Contributor slug not updating automatically #13 ), social links were not being correctly pushed to the frontend;How:
/
commands;Screenshots:
New Author socials fields
SEO Plugin
Configuring meta description:
How it is rendered when sharing:
Live Preview
Updated Lexical editor