-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement category related content page #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes fetching structure to include type and target, expanding fetching to categories to facilitate pulling content to populate "content by category" pages. Adds a slug field to categories collection to enable fetching category by slug from its respective page. Updates function calling in ./authors/[slug]/page.tsx
Renames the AuthorContentGrid component to ContentGrid as it will be used in "contents by category" page.
Simplifies and fixes total article calculation logic to loop through the different content types and increment its lengts. Closes #33
Also adds extra typing to fetchContentFromAuthorOrCategory 'type' parameter
…rs/setup-category-page
Adds Category pages that fetches content per category, based on slug, and displays in grid as well as pointing to other existing categories. Currently displays all categories but can be changed to related / parent / child categories in the feature
Enables category pill to link directly to the category content page. Updates SearchBar to disable link function in order to retain filtering behaviour.
✅ Deploy Preview for content-sub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davelange
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Though when I go to a category page on the deployed site, it's a 404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
fetchContentFromAuthor
, enabling category-based search;Categories
collection, adding a slug field to enable content searching;Also includes minor changes and refactors to other components to extend reusability.