Refactor Wordle hooks #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why Wordle3 hooks were using a local account strucutre that had to destructure the account into `account.address` in order to separate address and private key which is not what will happen in production. ## How By refactoring the hooks' argument to stop destructuring the account as `WagmiProvider` passes the correct data structure to work as intended.
DavideSilva
approved these changes
Nov 7, 2024
## Why The `useEffect` hook was constantly pinging the network while looking for changes in `playerGuesses` which lead excessive network requests. ## How By changing the `useEffect` to watch only for address changes and shifting the `playerGuess` update to `handleTryGuess`, which makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Wordle3 hooks were using a local account strucutre that had to destructure the account into
account.addressin order to separate address and private key which is not what will happen in production.How
By refactoring the hooks' argument to stop destructuring the account as
WagmiProviderpasses the correct data structure to work as intended.