finalize game logic #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds attempt limit checking and message emiting; - refactors contract contruction;
rccsousa
commented
Oct 30, 2024
Comment on lines
+127
to
+128
| emit RemainingAttempts(7 - ATTEMPTS, "Attempts left."); // Clear message | ||
| return false; // Incorrect guess |
There was a problem hiding this comment.
I could not replicate this on forge using vm.expectEmit(true, true, true, true) and replicating the message.
Was getting the error that the log was not being emitted, however things were logging correctly. This is the right way to setup emit events, right?
DavideSilva
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
A mechanism to handle attempts and emit success / failure messages is necessary in order to smoothen game flow.
How:
By implementing a
handleAttemptfunction that checks if all attempts have been spent and processing new attempts.Also refactors contract construction.