feat: client input caching #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
reviewed
Aug 26, 2024
bin/host/src/main.rs
Outdated
| // and decide on whether to panic later. | ||
| // | ||
| // On the other hand chain ID is always needed. | ||
| let (rpc_url, chain_id) = match (args.rpc_url, args.chain_id) { |
There was a problem hiding this comment.
Small code-style thing, but it might be cleaner as a separate function instead of shoved into this already long function
bin/host/src/main.rs
Outdated
| } | ||
| }; | ||
|
|
||
| let client_input_from_cache = if let Some(cache_dir) = args.cache_dir.as_ref() { |
There was a problem hiding this comment.
same here, might be nice to have this as a separate function for cleanliness / readability purposes
|
@puma314 Refactored a bit to cut down the spaghetti. |
puma314
approved these changes
Aug 27, 2024
xJonathanLEI
force-pushed
the
dev/input_cache
branch
from
2452c09
to
2c7e598
Compare
|
Rebased due to conflicts. Will merge once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to cache client input in the exact same format that would be fed into the client program. When used in combination with
--chain-idthis allows to host to run completely offline.