Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revm semver violation #56

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

xJonathanLEI
Copy link
Contributor

Fixes the revm SemVer violation issue documented in bluealloy/revm#1812 by temporarily pinning the versions.

Also adds a CI check that make sure we can build the library in a lockless state (as would be for downstream libraries or applications) importing RSP.

Copy link
Contributor

@yuwen01 yuwen01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- just wanted a little clarification for my personal understanding on the CI test.

.github/workflows/pr.yml Show resolved Hide resolved
@yuwen01 yuwen01 merged commit 3647076 into succinctlabs:main Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants