Conversation
Godrik0
suggested changes
Dec 7, 2025
|
|
||
|
|
||
| def uncurry(function, lenght_arg): | ||
| if lenght_arr < 0: |
| @@ -0,0 +1,32 @@ | |||
| def __curry(function, length_arg, args): | |||
| if length_arg < len(args): | |||
| raise Exception("too many arguments") | |||
There was a problem hiding this comment.
Кидать общий класс Exception -- плохая практика. Нужно использовать более конкретные исключения.
Comment on lines
+5
to
+8
| try: | ||
| return function(*args) | ||
| except: | ||
| raise Exception("invalid arguments or invalid number of arguments") |
There was a problem hiding this comment.
Потенциально это может скрыть ошибку внутри полученной функции, например, деление на ноль и т.д.
Comment on lines
+2
to
+8
| if length_arg < len(args): | ||
| raise Exception("too many arguments") | ||
| if length_arg == len(args): | ||
| try: | ||
| return function(*args) | ||
| except: | ||
| raise Exception("invalid arguments or invalid number of arguments") |
There was a problem hiding this comment.
Не проверяется случай, когда пользователь указывает арность не соответствующую реальной.
Мы можем написать f_curry = curry(sum3, 100), ошибка появится только при вызове функции f_curry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.