Added custom security context to APS calculation hook #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwheeler
force-pushed
the
custom_security_context
branch
from
0b85368
to
01d6f4d
Compare
dwheeler
changed the title
dwheeler
force-pushed
the
custom_security_context
branch
from
01d6f4d
to
75042ac
Compare
dwheeler
force-pushed
the
custom_security_context
branch
from
75042ac
to
8520d10
Compare
mmarum-sugarcrm
requested changes
Oct 26, 2018
| //Set the security context to better track the source of changes | ||
| $context = Container::getInstance()->get(Context::class); | ||
| $subject = new ApsSubject($bean->id); | ||
| $context->activateSubject($subject); |
There was a problem hiding this comment.
Sergey had a suggestion of using a try catch finally block to make sure subject is deactivated when exceptions are thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet tested, WiP.
DO NOT MERGE