Get builds from store #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial mess that successfully gets download from store Needs lots of cleaning Cleaned up the code Simplify the authentication to dev builds community by using curl -L Update doc Update naming of DEV_COMMUNITY to be SUGARCRM
lschaefer-sugarcrm
force-pushed
the
get-builds-from-store
branch
from
2a610b4
to
d49ba1a
Compare
Initial mess that successfully gets download from store Needs lots of cleaning Cleaned up the code Simplify the authentication to dev builds community by using curl -L Update doc Update naming of DEV_COMMUNITY to be SUGARCRM
…builds-from-store
|
@mmarum-sugarcrm I'm not able to reply inline to your earlier comments, so....
It is a bit of a magic number. For some reason, if you attempt to download a zip file that doesn't exist, you get a zip file of 209b instead of 0b. I've added a comment in the code to explain this.
I opened #53 to track this. Can you review again? |
mmarum-sugarcrm
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #42. Note that the 8.0 builds are not yet in the store. You can test the functionality by replacing the names of the zips on lines 270, 274, and 278 with zips that are in the store like SugarEnt-7.9.3.0.zip.
This branch is built off of the integration-tests branch and should not be merged until PR #38 is merged. The new commit that is part of this PR is d49ba1a.