✨(frontend) improve NVDA navigation in DocShareModal #1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
2 times, most recently
from
3970af0 to
9880d1d
Compare
|
Size Change: +49 B (0%) Total Size: 3.65 MB
|
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
4 times, most recently
from
3256b4f to
28f34ce
Compare
AntoLC
reviewed
Sep 18, 2025
src/frontend/apps/e2e/__tests__/app-impress/doc-member-create.spec.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/components/quick-search/QuickSearchInput.tsx
Outdated
Show resolved
Hide resolved
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
4 times, most recently
from
8edf1e2 to
03d3bc0
Compare
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
from
03d3bc0 to
72b3b4b
Compare
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
from
72b3b4b to
da4ed5d
Compare
AntoLC
reviewed
Sep 22, 2025
There was a problem hiding this comment.
I don't understand why we have to update this test, the development does not seem to touch really this part.
I can see it is still mocking the users request, it should not, it is not asserting anymore that the users are correctly displayed.
There was a problem hiding this comment.
Yes I agree, that was a mistake !
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
3 times, most recently
from
51a37fd to
dde32e0
Compare
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
3 times, most recently
from
6861750 to
d86027b
Compare
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
2 times, most recently
from
ebe8134 to
f420622
Compare
AntoLC
approved these changes
Sep 22, 2025
fix NVDA focus and announcement issues in search modal combobox Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/share-modal-nvda
branch
from
f420622 to
ee3b05c
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix UX and accessibility violations in DocShareModal where QuickSearch auto-selected the first result on open, causing NVDA to immediately announce "John Doe impress@impress.world" despite focus being in the search input.
This violated UX principles (user consent, predictability) and WCAG
Proposal