fix error handling of DuckDB::Appender#append_float

[suketa]

Summary by CodeRabbit

• New Features
  • Added enhanced support for appending floating point values during data operations, with updated documentation and examples.
• Bug Fixes
  • Improved error notifications for numeric data insertions to provide clearer, more robust feedback on operation failures.

[coderabbitai]

Walkthrough

This pull request updates error handling in the DuckDB::Appender class. The error message now includes the append_float method along with append_uint16, append_uint32, and append_uint64. In the C extension, the method for appending floats was renamed from appender_append_float to the private appender__append_float, and its error raising was replaced by a boolean return value. Additionally, a corresponding public Ruby method append_float was added to the Appender class, which utilizes the new private method.

Changes

File(s)	Change Summary
CHANGELOG.md	Updated error message handling for DuckDB::Appender to now include the append_float method along with existing uint methods.
ext/duckdb/appender.c	Renamed appender_append_float to appender__append_float and made it a private method. Removed explicit error raising and now returns a boolean via duckdb_state_to_bool_value. Also updated method bindings accordingly.
lib/duckdb/appender.rb	Added new public method append_float(value) to the Appender class. The method calls the private _append_float(value) method and raises an error (raise_appender_error('failed to append_float')) if the appending fails.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant A as Appender (Ruby)
    participant C as _append_float (C Layer)

    U->>A: Call append_float(value)
    A->>C: Invoke _append_float(value)
    C-->>A: Return boolean result
    alt Append Failure
        A->>A: raise_appender_error('failed to append_float')
    else Append Success
        A-->>U: Return appended float value
    end

Loading

Possibly related PRs

• change error handling of DuckDB::Appender#append_uint8 #871: Updates error handling for append_uint8, which closely parallels the changes made for append_float.
• fix error handling of DuckDB::Append#append_uint32. #895: Introduces similar error handling improvements for append_uint32, relating directly to the error management adjustments in this PR.
• handle error of DuckDB::Appender#append_uint64. #896: Focuses on error reporting enhancements for append_uint64, establishing a direct connection with the current changes in error handling.

Poem

In a meadow of code I hop with cheer,
Tweaking errors so gentle and clear.
Now floats join the dance with grace so light,
Private and public in harmony bright.
With each line, my code garden blooms anew,
A rabbit's code tale—a joyful debut!
🐇💻✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f23a06c and 3009de4.

📒 Files selected for processing (3)

• CHANGELOG.md (1 hunks)
• ext/duckdb/appender.c (3 hunks)
• lib/duckdb/appender.rb (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: test (head, 1.1.3)
• GitHub Check: test (head, 1.2.0)
• GitHub Check: test (mswin, 1.1.1)
• GitHub Check: test (mswin, 1.1.3)
• GitHub Check: test (mswin, 1.2.0)
• GitHub Check: test (mingw, 1.1.1)
• GitHub Check: test (mingw, 1.1.3)
• GitHub Check: test (mingw, 1.2.0)
• GitHub Check: test (3.4.1, 1.1.1)
• GitHub Check: test (3.4.1, 1.1.3)
• GitHub Check: test (3.4.1, 1.2.0)
• GitHub Check: test (3.3.6, 1.1.1)
• GitHub Check: test (3.3.6, 1.1.3)
• GitHub Check: test (3.3.6, 1.2.0)
• GitHub Check: test (3.2.6, 1.1.1)
• GitHub Check: test (3.2.6, 1.1.3)
• GitHub Check: test (3.2.6, 1.2.0)
• GitHub Check: test (3.1.6, 1.1.1)
• GitHub Check: test (3.1.6, 1.1.3)
• GitHub Check: test (3.1.6, 1.2.0)

🔇 Additional comments (5)

lib/duckdb/appender.rb (1)

289-307: Well-implemented append_float method following consistent patterns.

The new append_float method follows the same pattern as other append methods in the class, with proper documentation, example usage, and consistent error handling via the private _append_float method and raise_appender_error.

CHANGELOG.md (1)

9-10: Appropriate changelog entry for the fix.

Good documentation of the fix for error handling in the appender methods, now including append_float.

ext/duckdb/appender.c (3)

19-19: Function declaration renamed to match private method convention.

Changed from appender_append_float to appender__append_float to match the naming pattern used for other private appender methods.

---

210-218: Error handling improved for float appending.

The function now follows the same pattern as other append methods, returning a boolean value instead of raising an error directly. This allows the Ruby wrapper to handle the error in a consistent way.

---

437-437: Method correctly registered as private.

The method is now properly registered as a private method with rb_define_private_method, consistent with other similar methods in the class.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.