Use navPlace from iiif-presentation gem #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
force-pushed
the
move-nav-place-to-gem
branch
from
f50b894 to
85e6ffd
Compare
peetucket
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #761 : moves navPlace generation from PURL (added here: #752) to the iiif-presentation gem, as well as removes knowledge of public-xml from the class that generates it (and instead leaves that knowledge in PURL).
HOLD since this requires a new release of the iiif-presentation gem first, currently in PR: iiif-prezi/osullivan#86This existing spec verifies that it continues to produce the expected output: https://github.com/sul-dlss/purl/blob/main/spec/features/iiif3_manifest_spec.rb#L385-L416