Allow non-geo content types to point to source collection #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #1305, which will restore the relations widget in Earthworks for scanned map content once it is reindexed.
jcoyne
requested changes
Jan 22, 2024
| @@ -64,6 +64,10 @@ def stub_mods_request(druid, body) | |||
| it 'contains date' do | |||
| expect(result['solr_year_i']).to eq [1603] | |||
| end | |||
|
|
|||
| it 'contains a reference to the source collection' do | |||
There was a problem hiding this comment.
Should there be a test for non-geo types?
There was a problem hiding this comment.
This test is for https://purl.stanford.edu/dc482zx1528, which is a map (not geo).
There was a problem hiding this comment.
Cool. I was confused by this being geo_config_spec.
There was a problem hiding this comment.
That's fair – geo_config is more accurately "earthworks_config" since it handles a bunch of things that aren't strictly geo.
jcoyne
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1305, which will restore the relations widget in
Earthworks for scanned map content once it is reindexed.