Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add topic values to bib_search #1331

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Add topic values to bib_search #1331

merged 1 commit into from
Feb 13, 2024

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Feb 7, 2024 •
edited
Loading

At least some of the sw_index_tests expect to search for words from the title + topics 🤷‍♂️

@cbeer cbeer marked this pull request as draft February 7, 2024 23:54
@cbeer cbeer marked this pull request as ready for review February 8, 2024 17:03
jcoyne
jcoyne requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for these changes?

@cbeer
Copy link
Member Author

cbeer commented Feb 12, 2024

It strikes me as premature to add tests for the new bib_search fields. We're still iterating on what's necessary in this field after setting sow=false, and there's probably several more round of iteration before we get the right data here.

@jcoyne jcoyne merged commit 7a1bb1a into main Feb 13, 2024
2 checks passed
@jcoyne jcoyne deleted the bib-search-topic branch February 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne jcoyne requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbeer @jcoyne