Skip to content

Commit

Permalink
Allow older version of doctrine dbal (#9)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-schranz authored Aug 8, 2024
1 parent 1b0075a commit 6991f4c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/test-application.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ jobs:
env:
SYMFONY_DEPRECATIONS_HELPER: weak

- php-version: '8.4'
coverage: false
dependency-versions: 'highest'
composer-options: '--ignore-platform-reqs'
env:
SYMFONY_DEPRECATIONS_HELPER: weak

services:
mysql:
image: mysql:5.7
Expand All @@ -63,6 +70,11 @@ jobs:
extensions: ctype, iconv, mysql
coverage: pcov

- name: Remove Lint Tools
# These tools are not required to run tests, so we are removing them to improve dependency resolving and
# testing lowest versions.
run: composer remove "*php-cs-fixer*" "*phpstan*" "*rector*" --dev --no-update

- name: Install composer dependencies
uses: ramsey/composer-install@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "sulu-bundle",
"require": {
"php": "8.0.* || 8.1.* || 8.2.* || 8.3.*",
"doctrine/dbal": "^3.3",
"doctrine/dbal": "^2.13 || ^3.0",
"doctrine/doctrine-bundle": "^2.5",
"doctrine/orm": "^2.11",
"psr/container": "^1.0 || ^2.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/phpstan/object-manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
static fn ($listener) => $listener instanceof ResolveTargetEntityListener,
));

if ($resolveTargetEntityListener) {
if (false !== $resolveTargetEntityListener) {
$objectManager->getEventManager()->removeEventListener([Events::loadClassMetadata], $resolveTargetEntityListener);
}

Expand Down

0 comments on commit 6991f4c

Please sign in to comment.