Merge pull request #63 from drmoog/txmuta

test for txins mutability, divide large test function in half

riemann/tests/tx/test_tx.py

@@ -535,8 +535,8 @@ def test_everything(self):
 
         self.assertEqual(res, helpers.RAW_P2SH_TO_P2PKH)
 
-    # TODO: Break up this monstrosity
-    def test_create_tx(self):
+    # TODO: Break up this monstrosity (further)
+    def test_tx_witness(self):
         t = tx.Tx(self.version, self.none_flag, self.tx_ins, self.tx_outs,
                   self.none_witnesses, self.lock_time)
 
@@ -586,6 +586,12 @@ def test_create_tx(self):
             'Invalid InputWitness. Expected instance of InputWitness.',
             str(context.exception))
 
+    def test_tx_inandout(self):
+        t = tx.Tx(self.version, self.none_flag, self.tx_ins, self.tx_outs,
+                  self.none_witnesses, self.lock_time)
+
+        self.assertEqual(t, helpers.P2PKH1['ser']['tx']['signed'])
+
         with self.assertRaises(ValueError) as context:
             tx_ins = [self.tx_ins[0] for _ in range(257)]
             tx.Tx(self.version, self.none_flag, tx_ins, self.tx_outs,
@@ -638,6 +644,16 @@ def test_create_tx(self):
             'Tx is too large. Expect less than 100kB. Got: ',
             str(context.exception))
 
+    def test_tx_inout_mutation(self):
+        t = tx.Tx(self.version, self.none_flag, self.tx_ins, self.tx_outs,
+                  self.none_witnesses, self.lock_time)
+
+        with self.assertRaises(TypeError, msg='That\'s immutable, honey'):
+            t.tx_ins = t.tx_ins + (1,)
+
+        with self.assertRaises(TypeError, msg='That\'s immutable, honey'):
+            t.tx_outs = t.tx_outs + (1,)
+
     def test_tx_id(self):
         t = tx.Tx(self.version, self.none_flag, self.tx_ins, self.tx_outs,
                   self.none_witnesses, self.lock_time)